Re: [PATCH 1/8] t1300: style updates

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Oct 24, 2012, 06:33 UTC
Message-ID: <50878BAB.60809@viscovery.net>
In-Reply-To: <20121023223554.GA17392@sigill.intra.peff.net>

Am 10/24/2012 0:35, schrieb Jeff King:

Show 5 quoted lines

> -test_expect_success 'non-match value' \
> -	'test wow = $(git config --get nextsection.nonewline !for)'
> +test_expect_success 'non-match value' '
> +	test wow = $(git config --get nextsection.nonewline !for)
> +'

Here's a case you forgot to update to test_cmp.

> +test_expect_success 'get-regexp variable with no value' '
> +	git config --get-regexp novalue > output &&
> +	 test_cmp expect output'

And while you are here, you might want to remove this extra space. ;)

Otherwise, looks fine.

-- Hannes

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.