From: Johannes Sixt <j.sixt@viscovery.net>
Date: Wed, 24 Oct 2012 06:33:15 GMT
Subject: Re: [PATCH 1/8] t1300: style updates
Message-ID: <50878BAB.60809@viscovery.net>
In-Reply-To: <20121023223554.GA17392@sigill.intra.peff.net>

Am 10/24/2012 0:35, schrieb Jeff King:
> -test_expect_success 'non-match value' \
> -	'test wow = $(git config --get nextsection.nonewline !for)'
> +test_expect_success 'non-match value' '
> +	test wow = $(git config --get nextsection.nonewline !for)
> +'

Here's a case you forgot to update to test_cmp.

> +test_expect_success 'get-regexp variable with no value' '
> +	git config --get-regexp novalue > output &&
> +	 test_cmp expect output'

And while you are here, you might want to remove this extra space. ;)

Otherwise, looks fine.

-- Hannes