[PATCH v5 04/11] repo: add structure max object size metrics
- From
- Eslam reda ragheb via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Feb 27, 2026, 19:30 UTC
- Message-ID
- <504d9cf7a0dbd663ea88c75217e1564504a60937.1772220640.git.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.2208.v5.git.git.1772220640.gitgitgadget@gmail.com>
From: Eslam reda ragheb <eslam.reda.div@gmail.com>
Extend git repo structure with maximum inflated and on-disk object sizes, both per type and overall max values.
This complements existing totals by highlighting outliers that often drive repository bloat analysis.
The implementation updates object counting to track per-type maxima while walking reachable objects.
It exposes those values in both table and keyvalue formats for scripts and human output.
Signed-off-by: Eslam reda ragheb <eslam.reda.div@gmail.com> --- builtin/repo.c | 87 +++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 86 insertions(+), 1 deletion(-)
diff --git a/builtin/repo.c b/builtin/repo.c index e5078e5459..a2fc3fd8cc 100644 --- a/builtin/repo.c +++ b/builtin/repo.c @@ -426,7 +426,9 @@ struct object_values { struct object_stats { struct object_values type_counts; struct object_values inflated_sizes; + struct object_values max_inflated_sizes; struct object_values disk_sizes; + struct object_values max_disk_sizes; }; struct repo_structure { @@ -529,6 +531,20 @@ static inline size_t get_total_object_values(struct object_values *values) return values->tags + values->commits + values->trees + values->blobs; } +static inline size_t get_max_object_value(struct object_values *values) +{ + size_t max = values->commits; + + if (values->trees > max) + max = values->trees; + if (values->blobs > max) + max = values->blobs; + if (values->tags > max) + max = values->tags; + + return max; +} + static void stats_table_setup_structure(struct stats_table *table, struct repo_structure *stats) { @@ -583,6 +599,26 @@ static void stats_table_setup_structure(struct stats_table *table, " * %s", _("Blobs")); stats_table_size_addf(table, objects->disk_sizes.tags, " * %s", _("Tags")); + + stats_table_size_addf(table, objects->max_inflated_sizes.commits, + " * %s", _("Largest commit")); + stats_table_size_addf(table, objects->max_inflated_sizes.trees, + " * %s", _("Largest tree")); + stats_table_size_addf(table, objects->max_inflated_sizes.blobs, + " * %s", _("Largest blob")); + stats_table_size_addf(table, objects->max_inflated_sizes.tags, + " * %s", _("Largest tag")); + + stats_table_size_addf(table, get_max_object_value(&objects->max_disk_sizes), + " * %s", _("Largest disk size")); + stats_table_size_addf(table, objects->max_disk_sizes.commits, + " * %s", _("Commits")); + stats_table_size_addf(table, objects->max_disk_sizes.trees, + " * %s", _("Trees")); + stats_table_size_addf(table, objects->max_disk_sizes.blobs, + " * %s", _("Blobs")); + stats_table_size_addf(table, objects->max_disk_sizes.tags, + " * %s", _("Tags")); } static void stats_table_print_structure(const struct stats_table *table) @@ -661,6 +697,9 @@ static void stats_table_clear(struct stats_table *table) static void structure_keyvalue_print(struct repo_structure *stats, char key_delim, char value_delim) { + size_t max_inflated_size = get_max_object_value(&stats->objects.max_inflated_sizes); + size_t max_disk_size = get_max_object_value(&stats->objects.max_disk_sizes); + printf("references.branches.count%c%" PRIuMAX "%c", key_delim, (uintmax_t)stats->refs.branches, value_delim); printf("references.tags.count%c%" PRIuMAX "%c", key_delim, @@ -688,6 +727,28 @@ static void structure_keyvalue_print(struct repo_structure *stats, printf("objects.tags.inflated_size%c%" PRIuMAX "%c", key_delim, (uintmax_t)stats->objects.inflated_sizes.tags, value_delim); + printf("objects.max_inflated_size%c%" PRIuMAX "%c", key_delim, + (uintmax_t)max_inflated_size, value_delim); + printf("objects.commits.max_inflated_size%c%" PRIuMAX "%c", key_delim, + (uintmax_t)stats->objects.max_inflated_sizes.commits, value_delim); + printf("objects.trees.max_inflated_size%c%" PRIuMAX "%c", key_delim, + (uintmax_t)stats->objects.max_inflated_sizes.trees, value_delim); + printf("objects.blobs.max_inflated_size%c%" PRIuMAX "%c", key_delim, + (uintmax_t)stats->objects.max_inflated_sizes.blobs, value_delim); + printf("objects.tags.max_inflated_size%c%" PRIuMAX "%c", key_delim, + (uintmax_t)stats->objects.max_inflated_sizes.tags, value_delim); + + printf("objects.max_disk_size%c%" PRIuMAX "%c", key_delim, + (uintmax_t)max_disk_size, value_delim); + printf("objects.commits.max_disk_size%c%" PRIuMAX "%c", key_delim, + (uintmax_t)stats->objects.max_disk_sizes.commits, value_delim); + printf("objects.trees.max_disk_size%c%" PRIuMAX "%c", key_delim, + (uintmax_t)stats->objects.max_disk_sizes.trees, value_delim); + printf("objects.blobs.max_disk_size%c%" PRIuMAX "%c", key_delim, + (uintmax_t)stats->objects.max_disk_sizes.blobs, value_delim); + printf("objects.tags.max_disk_size%c%" PRIuMAX "%c", key_delim, + (uintmax_t)stats->objects.max_disk_sizes.tags, value_delim); + printf("objects.commits.disk_size%c%" PRIuMAX "%c", key_delim, (uintmax_t)stats->objects.disk_sizes.commits, value_delim); printf("objects.trees.disk_size%c%" PRIuMAX "%c", key_delim, @@ -772,6 +833,8 @@ static int count_objects(const char *path UNUSED, struct oid_array *oids, struct object_stats *stats = data->stats; size_t inflated_total = 0; size_t disk_total = 0; + size_t max_inflated = 0; + size_t max_disk = 0; size_t object_count; for (size_t i = 0; i < oids->nr; i++) { @@ -786,31 +849,53 @@ static int count_objects(const char *path UNUSED, struct oid_array *oids, OBJECT_INFO_SKIP_FETCH_OBJECT | OBJECT_INFO_QUICK) < 0) continue; + if (disk < 0) + continue; inflated_total += inflated; - disk_total += disk; + disk_total += (size_t)disk; + if (inflated > max_inflated) + max_inflated = inflated; + if ((size_t)disk > max_disk) + max_disk = (size_t)disk; } switch (type) { case OBJ_TAG: stats->type_counts.tags += oids->nr; stats->inflated_sizes.tags += inflated_total; + if (max_inflated > stats->max_inflated_sizes.tags) + stats->max_inflated_sizes.tags = max_inflated; stats->disk_sizes.tags += disk_total; + if (max_disk > stats->max_disk_sizes.tags) + stats->max_disk_sizes.tags = max_disk; break; case OBJ_COMMIT: stats->type_counts.commits += oids->nr; stats->inflated_sizes.commits += inflated_total; + if (max_inflated > stats->max_inflated_sizes.commits) + stats->max_inflated_sizes.commits = max_inflated; stats->disk_sizes.commits += disk_total; + if (max_disk > stats->max_disk_sizes.commits) + stats->max_disk_sizes.commits = max_disk; break; case OBJ_TREE: stats->type_counts.trees += oids->nr; stats->inflated_sizes.trees += inflated_total; + if (max_inflated > stats->max_inflated_sizes.trees) + stats->max_inflated_sizes.trees = max_inflated; stats->disk_sizes.trees += disk_total; + if (max_disk > stats->max_disk_sizes.trees) + stats->max_disk_sizes.trees = max_disk; break; case OBJ_BLOB: stats->type_counts.blobs += oids->nr; stats->inflated_sizes.blobs += inflated_total; + if (max_inflated > stats->max_inflated_sizes.blobs) + stats->max_inflated_sizes.blobs = max_inflated; stats->disk_sizes.blobs += disk_total; + if (max_disk > stats->max_disk_sizes.blobs) + stats->max_disk_sizes.blobs = max_disk; break; default: BUG("invalid object type");
-- gitgitgadget