Re: [PATCH v6 5/6] t1900: cover repo info path keys and path-format
- From
- Jialong Wang <jerrywang183@yahoo.com>
- Date
- Mar 19, 2026, 20:58 UTC
- Message-ID
- <20260319205854.15214-1-jerrywang183@yahoo.com>
- In-Reply-To
- <pull.2208.v6.git.git.1772428548.gitgitgadget@gmail.com>
Hi Eslam,
Thanks for working on this. I tried the v6 branch locally, and the path-key coverage looks good overall, but I think t1900 still misses a few non-default layouts that seem worth covering.
In particular, I think it would be useful to add coverage for:
- linked worktrees, where path.git-dir points into
.git/worktrees/<name>, path.common-dir still points at the main
.git, and path.toplevel points at the linked checkout - repositories created with --separate-git-dir, especially
path.git-dir with --path-format=relative - path.superproject-working-tree with --path-format=relative in a
submoduleI tested these locally against rev-parse and they seem to behave as expected, so they may make good follow-up coverage for this series.
Thanks, Jialong