Re: [PATCH 6/7] Remove unused and bad gettext block from git-am
- From
Stefano Lattarini <stefano.lattarini@gmail.com>
- Date
- Jul 21, 2012, 16:29 UTC
- Message-ID
- <500AD8F2.1000101@gmail.com>
- In-Reply-To
- <d1af1d40b0edbb8e356ecbb700cd0a7c13832a8f.1342884459.git.worldhello.net@gmail.com>
On 07/21/2012 05:50 PM, Jiang Xin wrote:
> Gettext message >
s/message/messages/ I think.
> should not start with '-' nor '--'. Since the '-d' and > '--dotest' options are not exist >
s/are not/do not/
> in OPTIONS_SPEC variable, >
s/OPTIONS_SPEC/the OPTIONS_SPEC/
> so it's safe to remove the block. >
This "so" is redundant, in light of the earlier "Since". I'd just remove it.
Regards, Stefano