Re: [PATCH 4/7] Remove obsolete LONG_USAGE which breaks xgettext

From: Stefano Lattarini <stefano.lattarini@gmail.com>
Date: Jul 21, 2012, 16:26 UTC
Message-ID: <500AD82B.9010604@gmail.com>
In-Reply-To: <941f7bd695e8a14c940a5b8e4214d2773ae82557.1342884459.git.worldhello.net@gmail.com>

On 07/21/2012 05:50 PM, Jiang Xin wrote:

Show 6 quoted lines

> The obsolete LONG_USAGE variable has the following message in it:
> 
>     A'\''--B'\''--C'\''
> 
> And such complex LONG_USAGE message will breaks xgettext when extract
>

s/extract/extracting/ I think.

> l10n messages. But if remove single quotes from the message,
>

s/remove/we remove/; or, if the passive voice is not a problem, you might reformulate the sentence as follows:

   But if single quotes are removed from the message, ...

> xgettext works fine on 'git-rebase.sh'.
> 
> Since there is a mordern
>

s/mordern/modern/

> OPTIONS_SPEC variable in use in this script,
> it's safe to remove the obsolte
>

s/obsolte/obsolete/

> USAGE and LONG_USAGE variables.
>

Regards,
  Stefano