Re: [PATCH 00/16] Header cleanups

From: Derrick Stolee <derrickstolee@github.com>
Date: Feb 23, 2023, 14:27 UTC
Message-ID: <4ef6665d-b924-6f81-06a4-b51ecccccfa8@github.com>
In-Reply-To: <pull.1485.git.1677139521.gitgitgadget@gmail.com>

On 2/23/2023 3:05 AM, Elijah Newren via GitGitGadget wrote:

> This series cleans up headers a bit, trying to remove excessive dependency
> on "cache.h". I created this series a while ago, but decided to clean it up
> and submit it due to Emily's recent thread and suggestion that this might be
> helpful to their efforts[1].

Thanks for doing this cleanup. It certainly doesn't look like an easy task.

I read the patches carefully and tried to point out anything that looked fishy and not fully supported by the commit message. However, some things are probably only fishy because it was the least-complicated time to make that change.

I'd be happy with this series as-is, allowing further improvements on top. I just wanted to poke a little at these bits that were not super-clear in case there was a possible improvement.

Thanks, -Stolee