Re: [PATCH 02/16] treewide: remove unnecessary git-compat-util.h includes in headers

From: Derrick Stolee <derrickstolee@github.com>
Date: Feb 23, 2023, 13:52 UTC
Message-ID: <14c2e90d-e68b-d0ad-f8d4-1842663b33c9@github.com>
In-Reply-To: <adafa655432dd13d1c727522377ac9a4b515b76a.1677139521.git.gitgitgadget@gmail.com>

On 2/23/2023 3:05 AM, Elijah Newren via GitGitGadget wrote:

Show 8 quoted lines

> From: Elijah Newren <newren@gmail.com>
> 
> Since git-compat-util.h needs to be included first in C files, having it
> appear in header files is unnecessary.  More importantly, having it
> included in header files seems to lead to folks leaving it out of C
> files, which makes it harder to verify that the rule is being followed.
> Remove it from header files, other than the ones that have been approved
> as alternate first includes.

...

>  compat/fsmonitor/fsm-ipc-win32.c       | 1 +
>  compat/fsmonitor/fsm-settings-darwin.c | 1 +

It looks like you have a couple .c files here that belong in the previous patch.

Thanks, -Stolee