Re: [PATCH 07/16] hex.h: move some hex-related declarations from cache.h

From: Derrick Stolee <derrickstolee@github.com>
Date: Feb 23, 2023, 14:11 UTC
Message-ID: <22ca24ee-39fe-013a-494a-ed7f140210fa@github.com>
In-Reply-To: <c9b1b27809298eb1b7a8c5e48866637268dc12a1.1677139522.git.gitgitgadget@gmail.com>

On 2/23/2023 3:05 AM, Elijah Newren via GitGitGadget wrote:

Show 7 quoted lines

> From: Elijah Newren <newren@gmail.com>
> 
> hex.c contains code for hex-related functions, but for some reason these
> functions were declared in the catch-all cache.h.  Move the function
> declarations into a hex.h header instead.
> 
> This also allows us to remove includes of cache.h from a few C files.

Show 9 quoted lines

> diff --git a/cache.h b/cache.h
> index daf6150bb3c..d0619ce2e63 100644
> --- a/cache.h
> +++ b/cache.h
> @@ -13,6 +13,7 @@
>  #include "string-list.h"
>  #include "pack-revindex.h"
>  #include "hash.h"
> +#include "hex.h"

Adding this to cache.h is definitely safe, but it makes it so .c files that consume the moved code do not _need_ to include hex.h like I think you want to imply at the end of this patch.

What changes if you drop this from your change?

Thanks, -Stolee