[PATCH v2 1/2] remote rename: demonstrate a bogus "remote exists" bug
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 19, 2017, 21:19 UTC
- Message-ID
- <4e3c94cb58052af1c0021b7e4c96ab4029afb7bb.1484860744.git.johannes.schindelin@gmx.de>
- In-Reply-To
- <cover.1484860744.git.johannes.schindelin@gmx.de>
Some users like to set `remote.origin.prune = true` in their ~/.gitconfig so that all of their repositories use that default.
However, our code is ill-prepared for this, mistaking that single entry to mean that there is already a remote of the name "origin", even if there is not.
This patch adds a test case demonstrating this issue.
Reported by Andrew Arnott.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- t/t5505-remote.sh | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh index 8198d8eb05..2c03f44c85 100755 --- a/t/t5505-remote.sh +++ b/t/t5505-remote.sh @@ -764,6 +764,13 @@ test_expect_success 'rename a remote with name prefix of other remote' ' ) ' +test_expect_failure 'rename succeeds with existing remote.<target>.prune' ' + git clone one four.four && + test_when_finished git config --global --unset remote.upstream.prune && + git config --global remote.upstream.prune true && + git -C four.four remote rename origin upstream +' + cat >remotes_origin <<EOF URL: $(pwd)/one Push: refs/heads/master:refs/heads/upstream
-- 2.11.0.windows.3