Re: [PATCH 0/2] Fix remote_is_configured()

From: Jeff King <peff@peff.net>
Date: Jan 17, 2017, 21:45 UTC
Message-ID: <20170117214504.y7fnpkgnugbtdxpz@sigill.intra.peff.net>
In-Reply-To: <cover.1484687919.git.johannes.schindelin@gmx.de>

On Tue, Jan 17, 2017 at 10:18:58PM +0100, Johannes Schindelin wrote:

Show 10 quoted lines

> A surprising behavior triggered the bug report in
> https://github.com/git-for-windows/git/issues/888: the mere existence of
> the config setting "remote.origin.prune" (in this instance, configured
> via ~/.gitconfig so that it applies to all repositories) fooled `git
> remote rename <source> <target>` into believing that the <target> remote
> is already there.
> 
> This patch pair demonstrates the problem, and then fixes it (along with
> potential similar problems, such as setting an HTTP proxy for remotes of
> a given name via ~/.gitconfig).

I thought it was intentional that any config "created" the remote, even without a url field. E.g., you can set:

  [remote "https://example.com/foo/git"]
  proxy = localhost:1234

and then a bare "git fetch https://example.com/foo/git" will respect it.

I admit that "prune" is probably useless without a fetch refspec, though.

Note that I don't disagree that the rule "it's not a remote unless it has a url" would be a lot saner. But I have a feeling you may be breaking some existing setups.

I grepped around in the list but I couldn't find any relevant discussion. So maybe I just dreamed it.

-Peff