Re: [PATCH v2 2/2] Be more careful when determining whether a remote was configured

From: Jeff King <peff@peff.net>
Date: Jan 19, 2017, 21:50 UTC
Message-ID: <20170119215016.j675tzhmhcku2y43@sigill.intra.peff.net>
In-Reply-To: <xmqqy3y6yb9i.fsf@gitster.mtv.corp.google.com>

On Thu, Jan 19, 2017 at 01:45:29PM -0800, Junio C Hamano wrote:

Show 11 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > I'm trying to figure out why "fetch --multiple" wouldn't just take a url
> > in the first place. I guess it is because multiple fetch is useless
> > without refspecs (since otherwise you're just writing to FETCH_HEAD,
> > which gets immediately overwritten).
> 
> This is probably a tangent, if FETCH_HEAD is overwritten, wouldn't
> that be a bug in the implementation of --multiple?  I somehow
> thought we had an option to tell second and subsequent "fetch" to
> append to FETCH_HEAD instead of overwriting it.

Maybe. I was just speculating on the reason.

I just disabled that check and tried it with two local repos:

  git init
  git fetch --multiple /path/to/one /path/to/two
  cat .git/FETCH_HEAD

and indeed it does seem to append.

The logic comes from 9c4a036b3 (Teach the --all option to 'git fetch', 2009-11-09), but it does not seem to give any reasoning. Nor could I find anything on the mailing list. <shrug>

-Peff