Re: [PATCH v5] move rust gitcore crate to a different subdirectory
- From
Mike Hommey <mh@glandium.org>
- Date
- Oct 30, 2026, 23:20 UTC
- Message-ID
- <4brq3bxkdq6ewviznwrg7uqgpp2j6xf2bladpmdrpaypcjp63t@lqfpwwagpbss>
- In-Reply-To
- <xmqqh5i6g3b5.fsf@gitster.g>
On Tue, Oct 27, 2026 at 03:57:02PM -0700, Junio C Hamano wrote:
Show 24 quoted lines
> Mike Hommey <mh@glandium.org> writes: > > > Having `Cargo.toml` at the top-level of the repository implies that one > > can run `cargo build` directly, but this doesn't produce anything useful > > on its own. > > > > Additionally, when including the git source as a submodule of a Rust > > project, it prevents the git source from being included at all in the > > crate package because cargo skips directories that contain a Cargo.toml, > > assuming that everything in the directory is relevant to the crate. > > > > Move all Rust-specific files into a dedicated `rust/` subdirectory. > > > > Signed-off-by: Mike Hommey <mh@glandium.org> > > --- > > I was looking at discussions that are older than a month whose > patches are not near 'next', and found this patch, which we haven't > seen any comments or updates on the discussion thread. > > It does not seem nobody, other than the original poster, for obvious > reasons, was enthused by the topic, and given that the exchange on > "what happens post Git 3.0?", I am not sure how badly we want to > keep this topic.
I, obviously, am still interested. Selfishly, I'd rather avoid having to maintain a fork just to move files around.
Mike