Re: What's cooking in git.git (Aug 2021, #02; Tue, 3)

From: Derrick Stolee <stolee@gmail.com>
Date: Aug 4, 2021, 14:22 UTC
Message-ID: <4aed0293-6a48-d370-3b72-496b7c631cb5@gmail.com>
In-Reply-To: <xmqqfsvpr8t5.fsf@gitster.g>

On 8/4/2021 3:03 AM, Junio C Hamano wrote: ...

> --------------------------------------------------
> [Stalled]

...

Show 9 quoted lines

> * lh/systemd-timers (2021-07-02) 3 commits
>  - maintenance: add support for systemd timers on Linux
>  - maintenance: `git maintenance run` learned `--scheduler=<scheduler>`
>  - cache.h: Introduce a generic "xdg_config_home_for(…)" function
> 
>  "git maintenance" scheduler learned to use systemd timers as a
>  possible backend.
> 
>  Waiting for reviews.

I just took another look at this series and see that there were a few items that have yet to be addressed. CC'ing Lénaïc and reviewers to see if those items will come in a v8. Here is a quick summary of my understanding:

* There are some non-ASCII characters in a code comment that are a
  bit non-standard and could be replaced with ASCII representations.
  (nit, but if re-rolling already this might be worth doing.)

* There is some discussion about using string_list_split() instead
  of hand-rolling a string splitter. Discussion decided that we
  should _not_ use strbuf_split_buf(). It would be nice to later
  create a version of strvec_split() that takes an arbitrary 
  delimiter, but isn't necessary for this series.

* There was some discussion about using #ifdef to make certain
  logic be compiled in or not. This seems (to me) less important
  in the case of returning 0 or 1, but in the third patch there
  is a large set of logic that is only compiled on Linux, which
  seems like it should match the pattern of the other methods,
  if possible.

Again, this is just my drive-by summary, but hopefully it renews work on this topic.

Thanks, -Stolee