git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Aug 2021, #02; Tue, 3)

From
PWPhillip Wood <phillip.wood123@gmail.com>
Date
Aug 5, 2021, 09:55 UTC
Message-ID
<1a3e2551-a6b3-2628-f21f-f9281e581871@gmail.com>
In-Reply-To
<4aed0293-6a48-d370-3b72-496b7c631cb5@gmail.com>
On 04/08/2021 15:22, Derrick Stolee wrote:
Show 39 quoted lines
> On 8/4/2021 3:03 AM, Junio C Hamano wrote:
> ...
>> --------------------------------------------------
>> [Stalled]
> ...
>> * lh/systemd-timers (2021-07-02) 3 commits
>>   - maintenance: add support for systemd timers on Linux
>>   - maintenance: `git maintenance run` learned `--scheduler=<scheduler>`
>>   - cache.h: Introduce a generic "xdg_config_home_for(…)" function
>>
>>   "git maintenance" scheduler learned to use systemd timers as a
>>   possible backend.
>>
>>   Waiting for reviews.
> 
> I just took another look at this series and see that there were a few
> items that have yet to be addressed. CC'ing Lénaïc and reviewers to
> see if those items will come in a v8. Here is a quick summary of my
> understanding:
> 
> * There are some non-ASCII characters in a code comment that are a
>    bit non-standard and could be replaced with ASCII representations.
>    (nit, but if re-rolling already this might be worth doing.)
> 
> * There is some discussion about using string_list_split() instead
>    of hand-rolling a string splitter. Discussion decided that we
>    should _not_ use strbuf_split_buf(). It would be nice to later
>    create a version of strvec_split() that takes an arbitrary
>    delimiter, but isn't necessary for this series.
> 
> * There was some discussion about using #ifdef to make certain
>    logic be compiled in or not. This seems (to me) less important
>    in the case of returning 0 or 1, but in the third patch there
>    is a large set of logic that is only compiled on Linux, which
>    seems like it should match the pattern of the other methods,
>    if possible.
> 
> Again, this is just my drive-by summary, but hopefully it renews
> work on this topic.

I think that is a fair summary, I'd be happy to see us take this series as-is, the code is fine and any small warts could be cleaned up in the future. I think Eric expressed a similar opinion in [1]. Lénaïc has been responsive to fixing bugs as well as taking on board other comments, I think we've reached the stage where it is not reasonable to keep asking for small changes.

Best Wishes
Phillip

[1] https://lore.kernel.org/git/CAPig+cT-x4_YuxmmoFw62jFqKRFJrS_UkyNOkdQz9-Gwec3QCQ@mail.gmail.com

> Thanks,
> -Stolee
> 
Previous: Jeff KingNext: Taylor Blau
Message 17 of 18 in “What's cooking in git.git (Aug 2021, #02; Tue, 3)”
  1. Junio C HamanoAug 4, 2021
  2. Ævar Arnfjörð BjarmasonAug 4, 2021
  3. Junio C HamanoAug 4, 2021
  4. Ævar Arnfjörð BjarmasonAug 4, 2021
  5. Junio C HamanoAug 4, 2021
  6. Ævar Arnfjörð BjarmasonAug 4, 2021
  7. Junio C HamanoAug 4, 2021
  8. SZEDER GáborAug 4, 2021
  9. SZEDER GáborAug 4, 2021
  10. Ævar Arnfjörð BjarmasonAug 4, 2021
  11. Junio C HamanoAug 5, 2021
  12. Ævar Arnfjörð BjarmasonAug 5, 2021
  13. SZEDER GáborAug 30, 2021
  14. SZEDER GáborAug 4, 2021
  15. Derrick StoleeAug 4, 2021
  16. Jeff KingAug 4, 2021
  17. Phillip WoodAug 5, 2021
  18. Taylor BlauAug 5, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.