Re: What's cooking in git.git (Aug 2021, #02; Tue, 3)

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Aug 4, 2021, 18:06 UTC
Message-ID: <20210804180658.GG23408@szeder.dev>
In-Reply-To: <87wnp1mqv2.fsf@evledraar.gmail.com>

On Wed, Aug 04, 2021 at 12:22:44PM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 14 quoted lines

> > * ab/progress-users-adjust-counters (2021-07-23) 3 commits
> >  - entry: show finer-grained counter in "Filtering content" progress line
> >  - midx: don't provide a total for QSORT() progress
> >  - commit-graph: fix bogus counter in "Scanning merged commits" progress line
> >
> >  The code to show progress indicator in a few codepaths did not
> >  cover between 0-100%, which has been corrected.
> >
> >  Waiting for a clarification.
> >  cf. <xmqqbl6slmer.fsf@gitster.g>
> 
> I think that what SZEDER had to say in
> https://lore.kernel.org/git/20210802220506.GF23408@szeder.dev/ should be
> enough to clear this to proceed forward.

Note that I also pointed out errors in the commit messages that should be addressed before this patch series advances; see:

  https://public-inbox.org/git/20210802210759.GD23408@szeder.dev/
  https://public-inbox.org/git/20210802214827.GE23408@szeder.dev/

But none of these patches fixes regressions introduced in this release cycle, so it's not urgent.

Show 12 quoted lines

> I.e. this topic is missing his subsequent
> https://lore.kernel.org/git/20210620200303.2328957-7-szeder.dev@gmail.com/
> patch.
> 
> But as he notes we only encounter this in one of our tests (and are
> unlikely to in the wild).
> 
> Between this topic and my ab/only-single-progress-at-once I think we're
> better off getting those basic fixes in before proceeding with any
> tricky additions of BUG() and other assertions, per what I noted in
> https://public-inbox.org/git/cover-00.25-00000000000-20210623T155626Z-avarab@gmail.com/;
> i.e. that some of those assertions were themselves buggy.