git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v8 3/4] submodule: fix sync handling of some relative superproject origin URLs

From
Jens Lehmann <jens.lehmann@web.de>
Date
Jun 5, 2012, 21:18 UTC
Message-ID
<4FCE77AA.6060005@web.de>
In-Reply-To
<1338716810-9881-4-git-send-email-jon.seymour@gmail.com>
Am 03.06.2012 11:46, schrieb Jon Seymour:
Show 6 quoted lines
> @@ -959,19 +985,32 @@ cmd_sync()
>  	while read mode sha1 stage sm_path
>  	do
>  		name=$(module_name "$sm_path")
> -		url=$(git config -f .gitmodules --get submodule."$name".url)
> +		# path from superproject origin repo to submodule origin repo

This comment is misleading as it only describes part of the truth, in a lot of cases it'll just be an absolute URL of the submodule.

> +		module_url=$(git config -f .gitmodules --get submodule."$name".url)

And I see no real value of renaming "url" to "module_url" here (but maybe that is just me).

So I'd vote for dropping that comment and the "url" to "module_url" change. But apart from that and the issues Junio mentioned in his response this series is looking good to me.

Previous: Jon SeymourNext: Junio C Hamano
Message 7 of 10 in “submodule: improve support for relative superproject origin URLs”
  1. 0/4 submodule: improve support for relative superproject origin URLsJon Seymour, Jun 3, 2012
  2. 1/4 submodule: additional regression tests for relative URLsJon Seymour, Jun 3, 2012
  3. 2/4 submodule: document failure to handle relative superproject origin URLsJon Seymour, Jun 3, 2012
  4. 3/4 submodule: fix sync handling of some relative superproject origin URLsJon Seymour, Jun 3, 2012
  5. Junio C HamanoJun 3, 2012
  6. Jon SeymourJun 3, 2012
  7. Jens LehmannJun 5, 2012
  8. Junio C HamanoJun 5, 2012
  9. Jon SeymourJun 6, 2012
  10. 4/4 submodule: fix handling of superproject origin URLs like foo, ./foo and ./foo/barJon Seymour, Jun 3, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.