From: Jens Lehmann <jens.lehmann@web.de>
Date: Tue, 05 Jun 2012 21:18:34 GMT
Subject: Re: [PATCH v8 3/4] submodule: fix sync handling of some relative superproject origin URLs
Message-ID: <4FCE77AA.6060005@web.de>
In-Reply-To: <1338716810-9881-4-git-send-email-jon.seymour@gmail.com>

Am 03.06.2012 11:46, schrieb Jon Seymour:
> @@ -959,19 +985,32 @@ cmd_sync()
>  	while read mode sha1 stage sm_path
>  	do
>  		name=$(module_name "$sm_path")
> -		url=$(git config -f .gitmodules --get submodule."$name".url)
> +		# path from superproject origin repo to submodule origin repo

This comment is misleading as it only describes part of the truth, in a lot
of cases it'll just be an absolute URL of the submodule.

> +		module_url=$(git config -f .gitmodules --get submodule."$name".url)

And I see no real value of renaming "url" to "module_url" here (but maybe
that is just me).

So I'd vote for dropping that comment and the "url" to "module_url" change.
But apart from that and the issues Junio mentioned in his response this
series is looking good to me.