git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v8 3/4] submodule: fix sync handling of some relative superproject origin URLs

From
Jon Seymour <jon.seymour@gmail.com>
Date
Jun 3, 2012, 23:52 UTC
Message-ID
<CAH3AnrrUNq9q54dxQidAKD5oAmTSs2hJnWR09jWxmZFYgnfKFw@mail.gmail.com>
In-Reply-To
<7v1ulwxd0o.fsf@alter.siamese.dyndns.org>
On Mon, Jun 4, 2012 at 8:10 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Jon Seymour <jon.seymour@gmail.com> writes:
>
> Style: please align case/esac and the labels on case arms (see how
> two existing nested case statements in this function are written).
Thanks.
> Didn't we add some workaround for implementations of sed that do not
> match and replace a possibly empty pattern?  Am I seeing the same
> breakage as c5bc42b (Avoid bug in Solaris xpg4/sed as used in
> submodule, 2012-04-09) addressed with this patch?

Have modified accordingly. It may not have mattered *much* in this case since I think normalisation during git submodule add would have ensured at least one matching character, but then I don't pretend to understand the nature of the Solaris issue and that would in any case, not protect against a manual .gitmodules edit.

I'll re-roll in a day or so after Jens (and/or others) have had a chance to comment.

jon.
Previous: Junio C HamanoNext: Jens Lehmann
Message 6 of 10 in “submodule: improve support for relative superproject origin URLs”
  1. 0/4 submodule: improve support for relative superproject origin URLsJon Seymour, Jun 3, 2012
  2. 1/4 submodule: additional regression tests for relative URLsJon Seymour, Jun 3, 2012
  3. 2/4 submodule: document failure to handle relative superproject origin URLsJon Seymour, Jun 3, 2012
  4. 3/4 submodule: fix sync handling of some relative superproject origin URLsJon Seymour, Jun 3, 2012
  5. Junio C HamanoJun 3, 2012
  6. Jon SeymourJun 3, 2012
  7. Jens LehmannJun 5, 2012
  8. Junio C HamanoJun 5, 2012
  9. Jon SeymourJun 6, 2012
  10. 4/4 submodule: fix handling of superproject origin URLs like foo, ./foo and ./foo/barJon Seymour, Jun 3, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.