git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] sequencer: export commit_list_append()

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
Apr 30, 2012, 21:07 UTC
Message-ID
<4F9EFF09.5010201@lsrfire.ath.cx>
In-Reply-To
<xmqqobqfbhae.fsf@junio.mtv.corp.google.com>
Am 26.04.2012 00:03, schrieb Junio C Hamano:
> I however wonder if we can name "next" a bit better, but cannot come up
> with a good name.  It is the location that holds the pointer to the new
> tail element if we append one.  Some places may call it "tail" but that
> gives a wrong impression that it points at the element at the end.

Perhaps tail_next? And it's perhaps a good idea to include it in the struct instead of letting callers maintain it separately.

René
Previous: Junio C HamanoNext: René Scharfe
Message 6 of 8 in “Possible segfault introduced in commit.c”
  1. Michael MuellerApr 25, 2012
  2. Jeff KingApr 25, 2012
  3. René ScharfeApr 25, 2012
  4. 1/3 sequencer: export commit_list_append()René Scharfe, Apr 25, 2012
  5. Junio C HamanoApr 25, 2012
  6. René ScharfeApr 30, 2012
  7. 2/3 revision: append to list instead of insert and reverseRené Scharfe, Apr 25, 2012
  8. 3/3 commit: remove commit_list_reverse()René Scharfe, Apr 25, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.