Re: [PATCH 1/3] sequencer: export commit_list_append()

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 25, 2012, 22:03 UTC
Message-ID: <xmqqobqfbhae.fsf@junio.mtv.corp.google.com>
In-Reply-To: <4F98600F.6000404@lsrfire.ath.cx>

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

> This function can be used in other parts of git.  Give it a new home
> in commit.c.
>
> Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>

This makes sense. I got confused every time I had to "append to tail" and had to draw boxes-and-arrows picture to make sure I understand how to use "\(.*\) = &commit_list_insert(something, \1)->next" correctly.

There probably are tons of places that can use this thing.

    $ git grep -c -e '\&commit_list_insert(.*)->next'
    builtin/commit.c:4
    builtin/diff-tree.c:1
    builtin/merge.c:3
    commit.c:4
    revision.c:5

I however wonder if we can name "next" a bit better, but cannot come up with a good name. It is the location that holds the pointer to the new tail element if we append one. Some places may call it "tail" but that gives a wrong impression that it points at the element at the end.