git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: push.default: current vs upstream

From
ASAndrew Sayers <andrew-git@pileofstuff.org>
Date
Apr 12, 2012, 21:16 UTC
Message-ID
<4F874639.5090207@pileofstuff.org>
In-Reply-To
<20120412071150.GB31122@sigill.intra.peff.net>
On 12/04/12 08:11, Jeff King wrote:
Show 11 quoted lines
> On Sat, Apr 07, 2012 at 09:40:26AM +0100, Andrew Sayers wrote:
> 
>> On a slight aside, should we add @{downstream} to describe the opposite
>> of @{upstream}?  Seeing that around the place would give intermediate
>> users a clue about why pull and push aren't as related as they think,
>> and would be useful here and there in code (e.g. __git_ps1 could show a
>> better bash prompt with GIT_PS1_SHOWUPSTREAM).
> 
> Maybe. I don't really see how it is useful, but maybe you want to flesh
> our your proposal with some examples? I do not use __git_ps1, so I'm not
> sure what you want to improve there.

This discussion has highlighted the fact that a lot of people (myself included) had difficulty with the idea that push and pull could be asymmetrical operations. Speaking for myself, push/pull/upstream/downstream/etc. has always been one of those things in my peripheral vision that worked well enough that I never really thought about it. I think this is a fairly important bug in the documentation, which I guess didn't come across when I suggested a solution that was mostly about code.

I could be wrong, but looking over this discussion suggests to me a pattern where people who actually thought about this stuff understood it pretty quickly, whereas those of us who hadn't previously thought about it had to unlearn the vague notion that "upstream" was somehow both the place you push to and the place you pull from, despite being incompatible with the meaning of the word.

I described this before as being "in my peripheral vision", which is as different from being in central vision (like it is for you guys) as it is different from being out of vision altogether (like it is for new people). Peripheral processing is a notoriously troubled route for ideas, because people tend to pick up on cues and internalise them in irrational ways without noticing. A classic version control example is how nobody ever said "commits are expensive and should be used cautiously", but everyone just sort of came to that conclusion without really thinking about it. As soon as DVCSs forced us to actually focus on the problem and think about it rationally, it became obvious that we needed to unlearn the vague assumption and go with a model that made more sense.

I'm pretty sure the cue I internalised to make me think "push" and "pull" were symmetrical was that the word "upstream" gets thrown around a lot in the documentation, whereas nobody ever uses the word "downstream". Having heard "upstream this" and "upstream that" every time I opened a man page, the word "upstream" just naturally popped into my head when I wondered where `git push` went. Just to be clear - I'm not arguing that anybody that consciously asked themselves the question "where does `git push` go?" would rationally conclude the answer is "upstream", I'm saying that those of us who never really thought about it had a mental process bubbling away deep in some murky bit of our brain which plugged the gap in our understanding with the only word it knew.

So if the problem is that the documentation cues the reader to think about upstreams but not to think about downstreams, the solution is to find excuses to talk more about downstreams. As far as I'm concerned @{upstream} means "the place that commits come from when I `git pull`", so it makes perfect sense to me that @{downstream} would mean "the place commits go to when I `git push`". That would let us write documentation like the following:

    Git has been optimised to make branching and merging very easy.
    Most git workflows involve using an upstream branch (that you pull
    other people's work from), your current branch (that you commit
    your changes to) and a downstream branch (that you push the
    combined work to).  To understand the this a bit better, try using
    these commands:
    git log # commits in your local repository
    git log @{upstream} # commits in your upstream branch
    git log @{downstream} # commits in your downstream branch
    git log HEAD..@{upstream} # commits you haven't pulled yet
    git log @{downstream}..HEAD # commits you haven't pushed yet
    A lot of workflows simplify the process by assuming that your
    upstream is also your downstream, and that both exist in some
    shared repository, but as far as git's concerned this is just one
    special case.

I realise the above is a bit simplistic and would need to be written better, but hopefully it demonstrates how code support for "downstream" terminology would let us write documentation that provides better cues about how the whole process works.

I mentioned __git_ps1 before as an example of where @{downstream} would be useful in code. The idea is that you can set your prompt to include e.g. "+3-2" if you have 3 commits to push and 2 commits to pull, which probably tells you lies right now when your push target happens not to be the same as your upstream.

	- Andrew
Previous: Junio C HamanoNext: Junio C Hamano
Message 41 of 152 in “[ANNOUNCE] Git 1.7.10-rc3”
  1. Junio C HamanoMar 28, 2012
  2. Jeff KingMar 29, 2012
  3. Junio C HamanoMar 29, 2012
  4. Jeff KingMar 29, 2012
  5. Junio C HamanoMar 30, 2012
  6. push.default: current vs upstreamJeff King, Mar 30, 2012
  7. Junio C HamanoMar 30, 2012
  8. Jeff KingMar 30, 2012
  9. Junio C HamanoMar 30, 2012
  10. Jeff KingMar 30, 2012
  11. Junio C HamanoMar 30, 2012
  12. Jeff KingMar 30, 2012
  13. Junio C HamanoMar 30, 2012
  14. Nathan GrayMar 31, 2012
  15. Seth RobertsonMar 31, 2012
  16. Junio C HamanoApr 1, 2012
  17. Nathan GrayApr 1, 2012
  18. Matthieu MoyApr 2, 2012
  19. Junio C HamanoApr 2, 2012
  20. Matthieu MoyApr 2, 2012
  21. Junio C HamanoApr 2, 2012
  22. Matthieu MoyApr 2, 2012
  23. Junio C HamanoApr 2, 2012
  24. Matthieu MoyApr 2, 2012
  25. Junio C HamanoApr 2, 2012
  26. demerphqApr 2, 2012
  27. Matthieu MoyApr 2, 2012
  28. demerphqApr 4, 2012
  29. Jeff KingApr 5, 2012
  30. Matthieu MoyApr 5, 2012
  31. Jeff KingApr 6, 2012
  32. Matthieu MoyApr 6, 2012
  33. Jeff KingApr 6, 2012
  34. Junio C HamanoApr 6, 2012
  35. Jehan BingApr 6, 2012
  36. Michael HaggertyApr 7, 2012
  37. Jeff KingApr 7, 2012
  38. Andrew SayersApr 7, 2012
  39. Jeff KingApr 12, 2012
  40. Junio C HamanoApr 12, 2012
  41. Andrew SayersApr 12, 2012
  42. Junio C HamanoApr 12, 2012
  43. Jeff KingApr 12, 2012
  44. Philip OakleyApr 12, 2012
  45. Junio C HamanoApr 13, 2012
  46. Andrew SayersApr 17, 2012
  47. Junio C HamanoApr 8, 2012
  48. Matthieu MoyApr 11, 2012
  49. Junio C HamanoApr 11, 2012
  50. Jeff KingApr 12, 2012
  51. Matthieu MoyApr 12, 2012
  52. Jeff KingApr 12, 2012
  53. Matthieu MoyApr 12, 2012
  54. Junio C HamanoApr 12, 2012
  55. Junio C HamanoApr 19, 2012
  56. Matthieu MoyApr 19, 2012
  57. Junio C HamanoApr 19, 2012
  58. 0/3 push.default upcomming changeMatthieu Moy, Apr 19, 2012
  59. 1/3 push: introduce new push.default mode "simple"Matthieu Moy, Apr 19, 2012
  60. Jeff KingApr 19, 2012
  61. Matthieu MoyApr 20, 2012
  62. 0/4 push.default upcomming changeMatthieu Moy, Apr 20, 2012
  63. 1/4 Documentation: explain push.default option a bit moreMatthieu Moy, Apr 20, 2012
  64. Jeff KingApr 20, 2012
  65. Junio C HamanoApr 20, 2012
  66. Michael HaggertyApr 21, 2012
  67. Junio C HamanoApr 21, 2012
  68. Michael HaggertyApr 21, 2012
  69. Junio C HamanoApr 21, 2012
  70. 2/4 push: introduce new push.default mode "simple"Matthieu Moy, Apr 20, 2012
  71. Jeff KingApr 20, 2012
  72. Zbigniew Jędrzejewski-SzmekApr 22, 2012
  73. Junio C HamanoApr 20, 2012
  74. Matthieu MoyApr 23, 2012
  75. 3/4 t5570: use explicit push refspecMatthieu Moy, Apr 20, 2012
  76. 4/4 push: start warning upcoming default change for push.defaultMatthieu Moy, Apr 20, 2012
  77. Jeff KingApr 20, 2012
  78. Matthieu MoyApr 22, 2012
  79. Junio C HamanoApr 23, 2012
  80. 0/7 push.default upcomming changeMatthieu Moy, Apr 23, 2012
  81. 1/7 Documentation: explain push.default option a bit moreMatthieu Moy, Apr 23, 2012
  82. Junio C HamanoApr 23, 2012
  83. Philip OakleyApr 23, 2012
  84. Junio C HamanoApr 23, 2012
  85. Philip OakleyApr 23, 2012
  86. 2/7 Undocument deprecated alias 'push.default=tracking'Matthieu Moy, Apr 23, 2012
  87. Junio C HamanoApr 23, 2012
  88. Ævar Arnfjörð BjarmasonJan 31, 2013
  89. Junio C HamanoJan 31, 2013
  90. Jonathan NiederJan 31, 2013
  91. Jonathan NiederJan 31, 2013
  92. Junio C HamanoJan 31, 2013
  93. Junio C HamanoJan 31, 2013
  94. Jonathan NiederJan 31, 2013
  95. Junio C HamanoJan 31, 2013
  96. Jonathan NiederJan 31, 2013
  97. Junio C HamanoJan 31, 2013
  98. Junio C HamanoJan 31, 2013
  99. Jonathan NiederJan 31, 2013
  100. Matthieu MoyJan 31, 2013
  101. Junio C HamanoJan 31, 2013
  102. Junio C HamanoJan 31, 2013
  103. Jonathan NiederJan 31, 2013
  104. Junio C HamanoFeb 1, 2013
  105. Jonathan NiederJan 31, 2013
  106. Philip OakleyJan 31, 2013
  107. 3/7 t5528-push-default.sh: add helper functionsMatthieu Moy, Apr 23, 2012
  108. Junio C HamanoApr 23, 2012
  109. Matthieu MoyApr 23, 2012
  110. Junio C HamanoApr 23, 2012
  111. Matthieu MoyApr 23, 2012
  112. Matthieu MoyApr 23, 2012
  113. Junio C HamanoApr 23, 2012
  114. Junio C HamanoApr 23, 2012
  115. 2/3 fixup! t5528-push-default.sh: add helper functionsJunio C Hamano, Apr 23, 2012
  116. 3/3 push: suggested updates to push configuration documentationJunio C Hamano, Apr 23, 2012
  117. 4/7 push: introduce new push.default mode "simple"Matthieu Moy, Apr 23, 2012
  118. Michael HaggertyApr 23, 2012
  119. Matthieu MoyApr 23, 2012
  120. Junio C HamanoApr 23, 2012
  121. Matthieu MoyApr 23, 2012
  122. 5/7 t5570: use explicit push refspecMatthieu Moy, Apr 23, 2012
  123. 6/7 push: document the future default change for push.default (matching -> simple)Matthieu Moy, Apr 23, 2012
  124. 7/7 push: start warning upcoming default change for push.defaultMatthieu Moy, Apr 23, 2012
  125. 0/7 push.default upcomming changeMatthieu Moy, Apr 24, 2012
  126. 1/7 Documentation: explain push.default option a bit moreMatthieu Moy, Apr 24, 2012
  127. 2/7 Undocument deprecated alias 'push.default=tracking'Matthieu Moy, Apr 24, 2012
  128. 3/7 t5528-push-default.sh: add helper functionsMatthieu Moy, Apr 24, 2012
  129. 4/7 push: introduce new push.default mode "simple"Matthieu Moy, Apr 24, 2012
  130. Junio C HamanoApr 25, 2012
  131. Matthieu MoyApr 25, 2012
  132. 5/7 t5570: use explicit push refspecMatthieu Moy, Apr 24, 2012
  133. 6/7 push: document the future default change for push.default (matching -> simple)Matthieu Moy, Apr 24, 2012
  134. 7/7 push: start warning upcoming default change for push.defaultMatthieu Moy, Apr 24, 2012
  135. Junio C HamanoApr 24, 2012
  136. 2/3 t5570: use explicit push refspecMatthieu Moy, Apr 19, 2012
  137. 3/3 push: start warning upcoming default change for push.defaultMatthieu Moy, Apr 19, 2012
  138. t5541: warning message is given even with --quietJunio C Hamano, Apr 26, 2012
  139. Matthieu MoyApr 26, 2012
  140. Give better 'pull' advice when pushing non-ff updates to current branchChristopher Tiwald, Apr 11, 2012
  141. Dmitry PotapovApr 6, 2012
  142. demerphqApr 6, 2012
  143. Dmitry PotapovApr 6, 2012
  144. demerphqApr 6, 2012
  145. Dmitry PotapovApr 6, 2012
  146. Junio C HamanoMar 30, 2012
  147. Jeff KingApr 3, 2012
  148. Jeff KingApr 3, 2012
  149. Junio C HamanoApr 3, 2012
  150. Junio C HamanoApr 3, 2012
  151. Jeff KingApr 5, 2012
  152. Felipe ContrerasApr 8, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.