Re: [PATCH 1/3] help: Fix help message for aliases

From: 김남형 <namhyung.kim@lge.com>
Date: Mar 15, 2012, 05:48 UTC
Message-ID: <4F6182C1.9080600@lge.com>
In-Reply-To: <7vipi6mo93.fsf@alter.siamese.dyndns.org>

Hi,

2012-03-15 2:23 PM, Junio C Hamano wrote:

Show 14 quoted lines

> Namhyung Kim <namhyung.kim@lge.com> writes:
>
>> -		printf("`git %s' is aliased to `%s'\n", argv[0], alias);
>> +		printf("`git %s' is aliased to `git %s'\n", argv[0], alias);
>
> NAK.
>
> What would the above change will do to one of my favorite alias?
>
> $ git help who
> `git who' is aliased to `!sh -c 'git log -1 --format="%an<%ae>" --author="$1"' -'
>
> Wouldn't removing "git " from the first phrase be a better solution?
>

Right. But as I replied to Jeff King, it can be improved to check whether the aliased output is such a complicated commands or not. Now I see that we can examine if the first letter is '!'.

Thanks, Namhyung