Re: [PATCH 1/3] help: Fix help message for aliases

From: Jeff King <peff@peff.net>
Date: Mar 15, 2012, 04:17 UTC
Message-ID: <20120315041734.GD4149@sigill.intra.peff.net>
In-Reply-To: <1331779969-8641-1-git-send-email-namhyung.kim@lge.com>

On Thu, Mar 15, 2012 at 11:52:47AM +0900, Namhyung Kim wrote:

Show 6 quoted lines

> The current "`git br' is aliased to `branch'" looks a bit
> strange. Prepend 'git' to aliased output too so that the
> end result will be looked like this:
> 
>  $ git help br
>  `git br' is aliased to `git branch'

I think that is a sensible improvement, but...

Show 11 quoted lines

> diff --git a/builtin/help.c b/builtin/help.c
> index 61ff798..f85c870 100644
> --- a/builtin/help.c
> +++ b/builtin/help.c
> @@ -445,7 +445,7 @@ int cmd_help(int argc, const char **argv, const char *prefix)
>  
>  	alias = alias_lookup(argv[0]);
>  	if (alias && !is_git_command(argv[0])) {
> -		printf("`git %s' is aliased to `%s'\n", argv[0], alias);
> +		printf("`git %s' is aliased to `git %s'\n", argv[0], alias);
>  		return 0;

What output does this produce for:

  $ git config alias.foo '!f() { git log $1@{u}..$1; }; f'
  $ git help foo

-Peff