git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] help: Fix help message for aliases

From
김남형 <namhyung.kim@lge.com>
Date
Mar 15, 2012, 05:15 UTC
Message-ID
<4F617AE2.9050700@lge.com>
In-Reply-To
<20120315041734.GD4149@sigill.intra.peff.net>
Hi,
2012-03-15 1:17 PM, Jeff King wrote:
Show 30 quoted lines
> On Thu, Mar 15, 2012 at 11:52:47AM +0900, Namhyung Kim wrote:
>
>> The current "`git br' is aliased to `branch'" looks a bit
>> strange. Prepend 'git' to aliased output too so that the
>> end result will be looked like this:
>>
>>   $ git help br
>>   `git br' is aliased to `git branch'
>
> I think that is a sensible improvement, but...
>
>> diff --git a/builtin/help.c b/builtin/help.c
>> index 61ff798..f85c870 100644
>> --- a/builtin/help.c
>> +++ b/builtin/help.c
>> @@ -445,7 +445,7 @@ int cmd_help(int argc, const char **argv, const char *prefix)
>>
>>   	alias = alias_lookup(argv[0]);
>>   	if (alias && !is_git_command(argv[0])) {
>> -		printf("`git %s' is aliased to `%s'\n", argv[0], alias);
>> +		printf("`git %s' is aliased to `git %s'\n", argv[0], alias);
>>   		return 0;
>
> What output does this produce for:
>
>    $ git config alias.foo '!f() { git log $1@{u}..$1; }; f'
>    $ git help foo
>
> ?
>

Oh, I didn't think of such a complicated case. Hmm, how about checking whether the first word is a git command or not:

		printf("`git %s' is aliased to `%s%s'\n", argv[0],
			is_git_command(first_word) ? "git " : "", alias);

Thanks, Namhyung

Previous: Jeff KingNext: Jeff King
Message 12 of 16 in “help: Fix help message for aliases”
  1. 1/3 help: Fix help message for aliasesNamhyung Kim, Mar 15, 2012
  2. 2/3 help: Add '--follow-alias' optionNamhyung Kim, Mar 15, 2012
  3. Junio C HamanoMar 15, 2012
  4. 김남형Mar 15, 2012
  5. Junio C HamanoMar 15, 2012
  6. Namhyung KimMar 15, 2012
  7. Junio C HamanoMar 15, 2012
  8. 3/3 help: Add 'help.follow-alias' config itemNamhyung Kim, Mar 15, 2012
  9. Junio C HamanoMar 15, 2012
  10. Namhyung KimMar 15, 2012
  11. Jeff KingMar 15, 2012
  12. 김남형Mar 15, 2012
  13. Jeff KingMar 15, 2012
  14. Junio C HamanoMar 15, 2012
  15. 김남형Mar 15, 2012
  16. Junio C HamanoMar 15, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.