git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] blame.c: Properly initialize strbuf after calling textconv_object(), again

From
Sebastian Schuberth <sschuberth@gmail.com>
Date
Nov 7, 2011, 17:31 UTC
Message-ID
<4EB815EB.30702@gmail.com>
In-Reply-To
<7vy5vr282s.fsf@alter.siamese.dyndns.org>
On 07.11.2011 17:47, Junio C Hamano wrote:
>> 2564aa4 started to initialize buf.alloc, but that should actually be one
>> more byte than the string length due to the trailing \0.
>
> Even when the conversion result is a zero-length string?

In this case, yes. The string buffer is initialized (and detached) in run_textconv, which calls strbuf_read, which grows the (yet empty) string to 8192 bytes. So alloc is always > 0, and the detach will trim alloc to len + 1.

However, Peff made another valid point and I'll send v2 soon.
-- 
Sebastian Schuberth
Previous: Junio C HamanoNext: Jeff King
Message 3 of 6 in “blame.c: Properly initialize strbuf after calling textconv_object(), again”
  1. blame.c: Properly initialize strbuf after calling textconv_object(), againSebastian Schuberth, Nov 7, 2011
  2. Junio C HamanoNov 7, 2011
  3. Sebastian SchuberthNov 7, 2011
  4. Jeff KingNov 7, 2011
  5. [PATCHv2] blame.c: Properly initialize strbuf after calling textconv_object(), againSebastian Schuberth, Nov 7, 2011
  6. Jeff KingNov 7, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.