From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Mon, 07 Nov 2011 17:31:23 GMT
Subject: Re: [PATCH] blame.c: Properly initialize strbuf after calling textconv_object(), again
Message-ID: <4EB815EB.30702@gmail.com>
In-Reply-To: <7vy5vr282s.fsf@alter.siamese.dyndns.org>

On 07.11.2011 17:47, Junio C Hamano wrote:

>> 2564aa4 started to initialize buf.alloc, but that should actually be one
>> more byte than the string length due to the trailing \0.
>
> Even when the conversion result is a zero-length string?

In this case, yes. The string buffer is initialized (and detached) in 
run_textconv, which calls strbuf_read, which grows the (yet empty) 
string to 8192 bytes. So alloc is always > 0, and the detach will trim 
alloc to len + 1.

However, Peff made another valid point and I'll send v2 soon.

-- 
Sebastian Schuberth