git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] blame.c: Properly initialize strbuf after calling textconv_object(), again

From
Sebastian Schuberth <sschuberth@gmail.com>
Date
Nov 7, 2011, 15:53 UTC
Message-ID
<4EB7FEE6.9000609@gmail.com>
2564aa4 started to initialize buf.alloc, but that should actually be one
more byte than the string length due to the trailing \0.
---
 builtin/blame.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin/blame.c b/builtin/blame.c
index 86c0537..45f0dcc 100644
--- a/builtin/blame.c
+++ b/builtin/blame.c
@@ -2114,7 +2114,7 @@ static struct commit *fake_working_tree_commit(struct diff_options *opt,
 		case S_IFREG:
 			if (DIFF_OPT_TST(opt, ALLOW_TEXTCONV) &&
 			    textconv_object(read_from, mode, null_sha1, &buf.buf, &buf_len)) {
-				buf.alloc = buf_len;
+				buf.alloc = buf_len + 1;
 				buf.len = buf_len;
 			}
 			else if (strbuf_read_file(&buf, read_from, st.st_size) != st.st_size)
-- 
1.7.8.rc0.46.g5ae0f.dirty
Next: Junio C Hamano
Message 1 of 6 in “blame.c: Properly initialize strbuf after calling textconv_object(), again”
  1. blame.c: Properly initialize strbuf after calling textconv_object(), againSebastian Schuberth, Nov 7, 2011
  2. Junio C HamanoNov 7, 2011
  3. Sebastian SchuberthNov 7, 2011
  4. Jeff KingNov 7, 2011
  5. [PATCHv2] blame.c: Properly initialize strbuf after calling textconv_object(), againSebastian Schuberth, Nov 7, 2011
  6. Jeff KingNov 7, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.