git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/7] pickaxe: plug memory leaks, deduplicate code

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
Oct 6, 2011, 15:59 UTC
Message-ID
<4E8DD065.3040607@lsrfire.ath.cx>
Hello,

this series aims to clean up the code for pickaxe (-S/-G). The first three patches plug minor to medium memory leaks.

	[PATCH 1/7] pickaxe: plug diff filespec leak with empty needle
	[PATCH 2/7] pickaxe: plug regex leak
	[PATCH 3/7] pickaxe: plug regex/kws leak

The next one moves a duplicate if/else cascade into its own helper function:

	[PATCH 4/7] pickaxe: factor out has_changes
The remainder unifies the code for pickaxe (-S) and log grep (-G).
	[PATCH 5/7] pickaxe: pass diff_options to contains and has_changes
	[PATCH 6/7] pickaxe: give diff_grep the same signature as has_changes
	[PATCH 7/7] pickaxe: factor out pickaxe
As a result the code should be shorter and easier to maintain.
 diffcore-pickaxe.c |  178 ++++++++++++++++++++-------------------------------
 1 files changed, 70 insertions(+), 108 deletions(-)
Next: René Scharfe
Message 1 of 9 in “pickaxe: plug memory leaks, deduplicate code”
  1. 0/7 pickaxe: plug memory leaks, deduplicate codeRené Scharfe, Oct 6, 2011
  2. 1/7 pickaxe: plug diff filespec leak with empty needleRené Scharfe, Oct 6, 2011
  3. 2/7 pickaxe: plug regex leakRené Scharfe, Oct 6, 2011
  4. 3/7 pickaxe: plug regex/kws leakRené Scharfe, Oct 6, 2011
  5. 4/7 pickaxe: factor out has_changesRené Scharfe, Oct 6, 2011
  6. 5/7 pickaxe: pass diff_options to contains and has_changesRené Scharfe, Oct 6, 2011
  7. 6/7 pickaxe: give diff_grep the same signature as has_changesRené Scharfe, Oct 6, 2011
  8. 7/7 pickaxe: factor out pickaxeRené Scharfe, Oct 6, 2011
  9. Junio C HamanoOct 7, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.