From: René Scharfe Date: Thu, 06 Oct 2011 15:59:33 GMT Subject: [PATCH 0/7] pickaxe: plug memory leaks, deduplicate code Message-ID: <4E8DD065.3040607@lsrfire.ath.cx> Hello, this series aims to clean up the code for pickaxe (-S/-G). The first three patches plug minor to medium memory leaks. [PATCH 1/7] pickaxe: plug diff filespec leak with empty needle [PATCH 2/7] pickaxe: plug regex leak [PATCH 3/7] pickaxe: plug regex/kws leak The next one moves a duplicate if/else cascade into its own helper function: [PATCH 4/7] pickaxe: factor out has_changes The remainder unifies the code for pickaxe (-S) and log grep (-G). [PATCH 5/7] pickaxe: pass diff_options to contains and has_changes [PATCH 6/7] pickaxe: give diff_grep the same signature as has_changes [PATCH 7/7] pickaxe: factor out pickaxe As a result the code should be shorter and easier to maintain. diffcore-pickaxe.c | 178 ++++++++++++++++++++------------------------------- 1 files changed, 70 insertions(+), 108 deletions(-)