git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/7] pickaxe: give diff_grep the same signature as has_changes

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
Oct 6, 2011, 16:50 UTC
Message-ID
<4E8DDC4A.8060001@lsrfire.ath.cx>
In-Reply-To
<4E8DD065.3040607@lsrfire.ath.cx>

Change diff_grep() to match the signature of has_changes() as a preparation for the next patch that will use function pointers to the two.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
---
 diffcore-pickaxe.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/diffcore-pickaxe.c b/diffcore-pickaxe.c
index 4d66ba9..226fa0c 100644
--- a/diffcore-pickaxe.c
+++ b/diffcore-pickaxe.c
@@ -45,7 +45,8 @@ static void fill_one(struct diff_filespec *one,
 	}
 }
 
-static int diff_grep(struct diff_filepair *p, regex_t *regexp, struct diff_options *o)
+static int diff_grep(struct diff_filepair *p, struct diff_options *o,
+		     regex_t *regexp, kwset_t kws)
 {
 	regmatch_t regmatch;
 	struct userdiff_driver *textconv_one = NULL;
@@ -114,7 +115,7 @@ static void diffcore_pickaxe_grep(struct diff_options *o)
 		/* Showing the whole changeset if needle exists */
 		for (i = 0; i < q->nr; i++) {
 			struct diff_filepair *p = q->queue[i];
-			if (diff_grep(p, &regex, o))
+			if (diff_grep(p, o, &regex, NULL))
 				goto out; /* do not munge the queue */
 		}
 
@@ -129,7 +130,7 @@ static void diffcore_pickaxe_grep(struct diff_options *o)
 		/* Showing only the filepairs that has the needle */
 		for (i = 0; i < q->nr; i++) {
 			struct diff_filepair *p = q->queue[i];
-			if (diff_grep(p, &regex, o))
+			if (diff_grep(p, o, &regex, NULL))
 				diff_q(&outq, p);
 			else
 				diff_free_filepair(p);
-- 
1.7.7
Previous: René ScharfeNext: René Scharfe
Message 7 of 9 in “pickaxe: plug memory leaks, deduplicate code”
  1. 0/7 pickaxe: plug memory leaks, deduplicate codeRené Scharfe, Oct 6, 2011
  2. 1/7 pickaxe: plug diff filespec leak with empty needleRené Scharfe, Oct 6, 2011
  3. 2/7 pickaxe: plug regex leakRené Scharfe, Oct 6, 2011
  4. 3/7 pickaxe: plug regex/kws leakRené Scharfe, Oct 6, 2011
  5. 4/7 pickaxe: factor out has_changesRené Scharfe, Oct 6, 2011
  6. 5/7 pickaxe: pass diff_options to contains and has_changesRené Scharfe, Oct 6, 2011
  7. 6/7 pickaxe: give diff_grep the same signature as has_changesRené Scharfe, Oct 6, 2011
  8. 7/7 pickaxe: factor out pickaxeRené Scharfe, Oct 6, 2011
  9. Junio C HamanoOct 7, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.