git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fetch: avoid quadratic loop checking for updated submodules

From
Jens Lehmann <jens.lehmann@web.de>
Date
Sep 13, 2011, 19:34 UTC
Message-ID
<4E6FB05C.6010202@web.de>
In-Reply-To
<7vwrdd5x61.fsf@alter.siamese.dyndns.org>
Am 12.09.2011 22:21, schrieb Junio C Hamano:
Show 5 quoted lines
> Jeff King <peff@peff.net> writes:
> 
>> Instead, this patch structures the code like this:
> 
> Yup, I agree that's the right way to do the other half of the issue.

Ack from me too! I tested it on the repo with 3k refs and the time went down from 142s to 1s (when applied to 3793ac56b4, as later versions of master contain my other half which would skip Peff's code).

On current master including my other half this takes 0.90s, while running with Peff's code on top of 3793ac56b4 it takes .96s. That is 6 hundreds of a second (7%) extra for not having to worry if one must run "git fetch --recurse-submodules" or not.

Previous: Junio C HamanoNext: Jens Lehmann
Message 3 of 17 in “fetch: avoid quadratic loop checking for updated submodules”
  1. fetch: avoid quadratic loop checking for updated submodulesJeff King, Sep 12, 2011
  2. Junio C HamanoSep 12, 2011
  3. Jens LehmannSep 13, 2011
  4. Jens LehmannSep 14, 2011
  5. Junio C HamanoSep 12, 2011
  6. Jeff KingSep 12, 2011
  7. Junio C HamanoSep 12, 2011
  8. Jeff KingSep 12, 2011
  9. Junio C HamanoSep 12, 2011
  10. Jens LehmannSep 13, 2011
  11. Jeff KingSep 13, 2011
  12. Marc BranchaudSep 14, 2011
  13. Jens LehmannSep 14, 2011
  14. Jeff KingSep 14, 2011
  15. Christian CouderSep 13, 2011
  16. Jeff KingSep 13, 2011
  17. Junio C HamanoSep 13, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.