Re: [PATCH] fetch: avoid quadratic loop checking for updated submodules
- From
Jeff King <peff@peff.net>
- Date
- Sep 14, 2011, 18:29 UTC
- Message-ID
- <20110914182933.GA15884@sigill.intra.peff.net>
- In-Reply-To
- <4E70F224.2080401@web.de>
On Wed, Sep 14, 2011 at 08:27:48PM +0200, Jens Lehmann wrote:
> Am 14.09.2011 00:17, schrieb Jeff King: > > One thing that could make it slightly less expensive (but I wouldn't > > worry about implementing until it becomes an issue): you do a full diff > [...]
Show 5 quoted lines
> I think this would work for the functionality which is implemented right > now. But with Frederik's gitfile work I hope to enable git to support > submodules being moved around in the work tree rather soonish. Then we > would be blind for any changes in the new location. Until it hurts us > I'd prefer to stay with the correct version, even if it is a bit slower.
Agreed. Let's worry about it if and when it becomes a performance issue.
Thanks for putting up my with my total cluelessness regarding what's happening in submodules. ;)
-Peff