git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fetch: avoid quadratic loop checking for updated submodules

From
Jeff King <peff@peff.net>
Date
Sep 13, 2011, 17:15 UTC
Message-ID
<20110913171506.GA32251@sigill.intra.peff.net>
In-Reply-To
<CAP8UFD3ULs9YLCaaJYGo-_A=KqO4yFy3WHJmO5b_hyRSPzA-Vg@mail.gmail.com>
On Tue, Sep 13, 2011 at 06:40:07PM +0200, Christian Couder wrote:
Show 7 quoted lines
> > +struct argv_array {
> > +       const char **argv;
> > +       unsigned int argc;
> > +       unsigned int alloc;
> > +};
> 
> But there is already such a struct in bisect.c!

Heh. I completely missed that. As I was writing it, I realized it would be a good thing to factor out, but most of the argv builders I checked weren't dynamic at all (they knew up front how big argv would need to be because they were copying).

As it turns out, our implementations are remarkably similar considering I hadn't read yours. It must mean they're both obviously correct. :)

> So it would be nice if you could refactor this and the argv_array
> functions in bisect.c in the same way you refactored sha1-array.

Will do. Junio, do you want me to re-roll the quadratic fix, or just build the refactoring on top?

-Peff
Previous: Christian CouderNext: Junio C Hamano
Message 16 of 17 in “fetch: avoid quadratic loop checking for updated submodules”
  1. fetch: avoid quadratic loop checking for updated submodulesJeff King, Sep 12, 2011
  2. Junio C HamanoSep 12, 2011
  3. Jens LehmannSep 13, 2011
  4. Jens LehmannSep 14, 2011
  5. Junio C HamanoSep 12, 2011
  6. Jeff KingSep 12, 2011
  7. Junio C HamanoSep 12, 2011
  8. Jeff KingSep 12, 2011
  9. Junio C HamanoSep 12, 2011
  10. Jens LehmannSep 13, 2011
  11. Jeff KingSep 13, 2011
  12. Marc BranchaudSep 14, 2011
  13. Jens LehmannSep 14, 2011
  14. Jeff KingSep 14, 2011
  15. Christian CouderSep 13, 2011
  16. Jeff KingSep 13, 2011
  17. Junio C HamanoSep 13, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.