git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 4/4] upload-archive: use start_command instead of fork

From
Johannes Sixt <j6t@kdbg.org>
Date
Aug 1, 2011, 21:20 UTC
Message-ID
<4E3718B4.6090803@kdbg.org>
In-Reply-To
<4E371109.7050500@lsrfire.ath.cx>
Am 01.08.2011 22:48, schrieb René Scharfe:
> So git archive gives the right results when writing to a pipe, but
> always the same wrong result when writing directly to a file.

This could indeed be a CRLF issue. archive-tar.c runs gzip to let it write to the original fd 1 (stdout). gzip is an MSYS program, and MSYS is "clever" and sets up the channel in text mode (CRLF conversion) if it is a regular file, but in binary mode if it is a pipe.

Without the gzip filter, git-archive writes to stdout itself. Since we have set up all our channels in binary mode, we do not suffer from the same problem for plain tar format.

So, I don't think we can do a lot about it, short of patching MSYS again...
-- Hannes
Previous: René ScharfeNext: René Scharfe
Message 16 of 33 in “port upload-archive to Windows”
  1. 0/4 port upload-archive to WindowsErik Faye-Lund, Jul 18, 2011
  2. 1/4 compat/win32/sys/poll.c: upgrade from upstreamErik Faye-Lund, Jul 18, 2011
  3. 2/4 mingw: fix compilation of poll-emulationErik Faye-Lund, Jul 18, 2011
  4. 3/4 enter_repo: do not modify inputErik Faye-Lund, Jul 18, 2011
  5. 4/4 upload-archive: use start_command instead of forkErik Faye-Lund, Jul 18, 2011
  6. Junio C HamanoJul 19, 2011
  7. Erik Faye-LundJul 28, 2011
  8. Jeff KingJul 28, 2011
  9. Jeff KingJul 28, 2011
  10. Jeff KingJul 28, 2011
  11. Erik Faye-LundAug 1, 2011
  12. Jeff KingAug 1, 2011
  13. Erik Faye-LundAug 1, 2011
  14. Jeff KingAug 1, 2011
  15. René ScharfeAug 1, 2011
  16. Johannes SixtAug 1, 2011
  17. René ScharfeAug 1, 2011
  18. René ScharfeAug 1, 2011
  19. Jeff KingAug 2, 2011
  20. René ScharfeAug 2, 2011
  21. Jeff KingAug 2, 2011
  22. Johannes SixtAug 2, 2011
  23. Jeff KingAug 3, 2011
  24. René ScharfeAug 6, 2011
  25. Johannes SixtAug 7, 2011
  26. Jeff KingAug 7, 2011
  27. René ScharfeAug 8, 2011
  28. Jeff KingAug 9, 2011
  29. René ScharfeAug 9, 2011
  30. Jeff KingAug 9, 2011
  31. Erik Faye-LundSep 29, 2011
  32. René ScharfeSep 29, 2011
  33. Erik Faye-LundSep 29, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.