Re: [PATCH v2 4/4] upload-archive: use start_command instead of fork
- From
Jeff King <peff@peff.net>
- Date
- Jul 28, 2011, 16:08 UTC
- Message-ID
- <20110728160845.GA14337@sigill.intra.peff.net>
- In-Reply-To
- <CABPQNSYtpRpNQVW=QvyfFhmWge5-C+k85bs2EJeK8k0jdfHzrw@mail.gmail.com>
On Thu, Jul 28, 2011 at 10:32:54AM +0200, Erik Faye-Lund wrote:
Show 8 quoted lines
> > Hmm, how well would this change work with recent archive-filter work by > > Peff, especially with the "when remote, disable some features" bits? > > > > Thanks for the notice. And no, not at all :( > > OK then. I'll probably have to rewrite this to use start_async + > dup-bonanza instead of start_command...
What's the issue? In my final version, I didn't think I changed run_upload_archive much at all. I would think there would be a trivial text conflict at the end of run_upload_archive, but the semantics should otherwise be the same.
Let me know if you need help untangling it.
-Peff