git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 4/4] upload-archive: use start_command instead of fork

From
Jeff King <peff@peff.net>
Date
Aug 3, 2011, 05:49 UTC
Message-ID
<20110803054958.GA7547@sigill.intra.peff.net>
In-Reply-To
<4E388A55.6080606@kdbg.org>
On Wed, Aug 03, 2011 at 01:37:57AM +0200, Johannes Sixt wrote:
Show 12 quoted lines
> Am 02.08.2011 20:13, schrieb Jeff King:
> > Hmm. So it's not _just_ the pipe vs file thing. What's different about
> > calling it from the shell, versus the way we call it from git-archive?
> 
> When the parent process of an MSYS process is itself an MSYS process,
> such as bash, then the child does not do its own
> binary-mode-vs.-text-mode detection, but just uses whatever it is told
> by the parent. This is achieved by MSYS's fork emulation.
> 
> But if the parent is a regular Windows program, such as git(-archive),
> then the autodection happens and file descriptors pointing to files are
> put into text mode.

Yuck. Well, I guess that's not really an option, then. The pipe trick sounds like the sanest option (it would even be trivial to switch the default value to "gzip -cn | cat" on Windows, but I assume "cat" has the same problem).

Thanks for the explanation.
-Peff
Previous: Johannes SixtNext: René Scharfe
Message 23 of 33 in “port upload-archive to Windows”
  1. 0/4 port upload-archive to WindowsErik Faye-Lund, Jul 18, 2011
  2. 1/4 compat/win32/sys/poll.c: upgrade from upstreamErik Faye-Lund, Jul 18, 2011
  3. 2/4 mingw: fix compilation of poll-emulationErik Faye-Lund, Jul 18, 2011
  4. 3/4 enter_repo: do not modify inputErik Faye-Lund, Jul 18, 2011
  5. 4/4 upload-archive: use start_command instead of forkErik Faye-Lund, Jul 18, 2011
  6. Junio C HamanoJul 19, 2011
  7. Erik Faye-LundJul 28, 2011
  8. Jeff KingJul 28, 2011
  9. Jeff KingJul 28, 2011
  10. Jeff KingJul 28, 2011
  11. Erik Faye-LundAug 1, 2011
  12. Jeff KingAug 1, 2011
  13. Erik Faye-LundAug 1, 2011
  14. Jeff KingAug 1, 2011
  15. René ScharfeAug 1, 2011
  16. Johannes SixtAug 1, 2011
  17. René ScharfeAug 1, 2011
  18. René ScharfeAug 1, 2011
  19. Jeff KingAug 2, 2011
  20. René ScharfeAug 2, 2011
  21. Jeff KingAug 2, 2011
  22. Johannes SixtAug 2, 2011
  23. Jeff KingAug 3, 2011
  24. René ScharfeAug 6, 2011
  25. Johannes SixtAug 7, 2011
  26. Jeff KingAug 7, 2011
  27. René ScharfeAug 8, 2011
  28. Jeff KingAug 9, 2011
  29. René ScharfeAug 9, 2011
  30. Jeff KingAug 9, 2011
  31. Erik Faye-LundSep 29, 2011
  32. René ScharfeSep 29, 2011
  33. Erik Faye-LundSep 29, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.