Re: [PATCH] gitk: Take only numeric version components when computing $git_version
Show 10 quoted lines
> [...]
> So after building from a tarball generated with "git archive", "git version"
> produces v1.7.4-rc1, producing errors from gitk, but after building
> from the git repo or a tarball generated with "make dist", the version
> is v1.7.4.rc1 (which gitk accepts).
>
> Anders's fix looks good to me for robustness reasons anyway, so
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
Show 7 quoted lines
> Maybe the substitution in GIT-VERSION-GEN should say something like
>
> VN=$(echo "$VN" | sed -e 's/-\([^r]\)/.\1/g')
>
> meaning the result for tagged rcs would not depend on whether git is
> present? Alternatively, DEF_VER could be set to v1.7.4.rc1, which
> does not seem as nice to me.
Mathias Lafeldt <misfire@debugon.org>