git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: Take only numeric version components when computing $git_version

From
Paul Mackerras <paulus@samba.org>
Date
Jan 18, 2011, 10:47 UTC
Message-ID
<20110118104742.GA3279@brick.ozlabs.ibm.com>
In-Reply-To
<4D355966.7090707@debugon.org>
On Tue, Jan 18, 2011 at 10:12:06AM +0100, Mathias Lafeldt wrote:
Show 13 quoted lines
> Jonathan Nieder wrote:
> > [...]
> > So after building from a tarball generated with "git archive", "git version"
> > produces v1.7.4-rc1, producing errors from gitk, but after building
> > from the git repo or a tarball generated with "make dist", the version
> > is v1.7.4.rc1 (which gitk accepts).
> > 
> > Anders's fix looks good to me for robustness reasons anyway, so
> > 
> >  Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
> > 
> 
> OK then. Junio? :)
I'll pick it up.
Paul.
Previous: Mathias LafeldtNext: Junio C Hamano
Message 6 of 8 in “BUG: gitk fails to parse 1.7.4-rc0 version string”
  1. Mathias LafeldtJan 4, 2011
  2. gitk: Take only numeric version components when computing $git_versionAnders Kaseorg, Jan 7, 2011
  3. Mathias LafeldtJan 11, 2011
  4. Jonathan NiederJan 13, 2011
  5. Mathias LafeldtJan 18, 2011
  6. Paul MackerrasJan 18, 2011
  7. Junio C HamanoJan 18, 2011
  8. Paul MackerrasJan 19, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.