From: Mathias Lafeldt <misfire@debugon.org>
Date: Tue, 18 Jan 2011 09:12:06 GMT
Subject: Re: [PATCH] gitk: Take only numeric version components when computing $git_version
Message-ID: <4D355966.7090707@debugon.org>
In-Reply-To: <20110113192243.GA20625@burratino>

Jonathan Nieder wrote:
> [...]
> So after building from a tarball generated with "git archive", "git version"
> produces v1.7.4-rc1, producing errors from gitk, but after building
> from the git repo or a tarball generated with "make dist", the version
> is v1.7.4.rc1 (which gitk accepts).
> 
> Anders's fix looks good to me for robustness reasons anyway, so
> 
>  Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
> 

OK then. Junio? :)

> Maybe the substitution in GIT-VERSION-GEN should say something like
> 
> 		VN=$(echo "$VN" | sed -e 's/-\([^r]\)/.\1/g')
> 
> meaning the result for tagged rcs would not depend on whether git is
> present?  Alternatively, DEF_VER could be set to v1.7.4.rc1, which
> does not seem as nice to me.