git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] submodule: fix relative url parsing for scp-style origin

From
Mark Levedahl <mlevedahl@gmail.com>
Date
Jan 11, 2011, 02:59 UTC
Message-ID
<4D2BC785.3090304@gmail.com>
In-Reply-To
<7v62tw7kx6.fsf@alter.siamese.dyndns.org>
On 01/10/2011 12:01 PM, Junio C Hamano wrote:
Show 17 quoted lines
> Thomas Rast<trast@student.ethz.ch>  writes:
>
>> The function resolve_relative_url was not prepared to deal with an
>> scp-style origin 'user@host:path' in the case where 'path' is only a
>> single component.  Fix this by extending the logic that strips one
>> path component from the $remoteurl.
>>
>> Also add tests for both styles of URLs.
>>
>> Noticed-by: Jeffrey Phillips Freeman<jeffrey.freeman@syncleus.com>
>> Signed-off-by: Thomas Rast<trast@student.ethz.ch>
>> ---
>>
>> If Mark agrees with the fix, I think this should go in before 1.7.4
>> since it's a pretty annoying bug.
> Seems obvious to me from a cursory look; thanks.
>

Looks ok to me. (FWIW, note that the original function handles user@host:~/path just fine :^).

Mark
Previous: Junio C Hamano
Message 7 of 7 in “submodule: fix relative url parsing for scp-style origin”
  1. submodule: fix relative url parsing for scp-style originThomas Rast, Jan 10, 2011
  2. Jonathan NiederJan 10, 2011
  3. Thomas RastJan 10, 2011
  4. Jonathan NiederJan 10, 2011
  5. Thomas RastJan 10, 2011
  6. Junio C HamanoJan 10, 2011
  7. Mark LevedahlJan 11, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.