Re: [PATCH] submodule: fix relative url parsing for scp-style origin

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 10, 2011, 17:22 UTC
Message-ID: <20110110172227.GA7882@burratino>
In-Reply-To: <201101101805.13251.trast@student.ethz.ch>

Thomas Rast wrote:

> Jonathan Nieder wrote:

Show 5 quoted lines

>> 	url = /local/path/with/a/colon:in:it
>> 	url = git://example.com/path/with/a/colon:in:it
>
> These work fine because the first case arm is "do we still have a
> slash?", and thus takes precedence over the colon splitting.

Ah, nice (sorry I missed that). So this can't create a regression and for what it's worth

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

>> 	url = simple.subdir.of.cwd
>
> That's caught by the outer 'case':

I meant if remoteurl is not fully qualified. For what it's worth, the answer seems to be that

	git clone repo newdir

replaces "repo" with the absolute path "$(pwd)/repo" and manually using a relative path as in

	git remote add origin subdir

creates a remote that is not usable, perhaps because different parts of the code treat it as relative to different directories (.git or the toplevel).

Sorry for the laziness --- I should have just checked.