From: Mark Levedahl Date: Tue, 11 Jan 2011 02:59:17 GMT Subject: Re: [PATCH] submodule: fix relative url parsing for scp-style origin Message-ID: <4D2BC785.3090304@gmail.com> In-Reply-To: <7v62tw7kx6.fsf@alter.siamese.dyndns.org> On 01/10/2011 12:01 PM, Junio C Hamano wrote: > Thomas Rast writes: > >> The function resolve_relative_url was not prepared to deal with an >> scp-style origin 'user@host:path' in the case where 'path' is only a >> single component. Fix this by extending the logic that strips one >> path component from the $remoteurl. >> >> Also add tests for both styles of URLs. >> >> Noticed-by: Jeffrey Phillips Freeman >> Signed-off-by: Thomas Rast >> --- >> >> If Mark agrees with the fix, I think this should go in before 1.7.4 >> since it's a pretty annoying bug. > Seems obvious to me from a cursory look; thanks. > Looks ok to me. (FWIW, note that the original function handles user@host:~/path just fine :^). Mark