Re: [PATCH 2/6] parse-options: do not infer PARSE_OPT_NOARG from option type

From: Stephen Boyd <bebarino@gmail.com>
Date: Nov 30, 2010, 08:13 UTC
Message-ID: <4CF4B22B.4060307@gmail.com>
In-Reply-To: <20101130030441.GC5326@burratino>

On 11/29/10 19:04, Jonathan Nieder wrote:

Show 16 quoted lines

> From: Stephen Boyd <bebarino@gmail.com>
> 
> Simplify the "takes no value" error path by relying on PARSE_OPT_NOARG
> being set correctly.  That is:
> 
>  - if the PARSE_OPT_NOARG flag is set, reject --opt=value
>    regardless of the option type;
>  - if the PARSE_OPT_NOARG flag is unset, accept --opt=value
>    regardless of the option type.
> 
> This way, the accepted usage more closely matches the usage advertised
> with --help-all.
> 
> No functional change intended, since the NOARG flag is only used
> with "boolean-only" option types in existing parse_options callers.
>

Signed-off-by: Stephen Boyd <bebarino@gmail.com>

> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> ---

Thanks for the nice words.