[PATCH v2 1/4] setup_git_env: print the true $GIT_DIR for debugging
- From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
- Date
- Oct 20, 2010, 03:11 UTC
- Message-ID
- <1287544320-8499-1-git-send-email-pclouds@gmail.com>
Ideally, GIT_DIR_ENVIRONMENT should be set before setup_git_env() is called and "setup: GIT_DIR defaults to .git" should never be printed out. If it is printed, $GIT_DIR is set up automatically, unexpectedly, elsewhere.
Checking for that line is a good way to know if setup code works properly.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> --- Second try. Better tests.
environment.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/environment.c b/environment.c index de5581f..e34adc3 100644 --- a/environment.c +++ b/environment.c @@ -91,8 +91,12 @@ static void setup_git_env(void) git_dir = read_gitfile_gently(DEFAULT_GIT_DIR_ENVIRONMENT); git_dir = git_dir ? xstrdup(git_dir) : NULL; } - if (!git_dir) + if (!git_dir) { + trace_printf("setup: GIT_DIR defaults to .git\n"); git_dir = DEFAULT_GIT_DIR_ENVIRONMENT; + } + else + trace_printf("setup: GIT_DIR set to %s\n", git_dir); git_object_dir = getenv(DB_ENVIRONMENT); if (!git_object_dir) { git_object_dir = xmalloc(strlen(git_dir) + 9);
-- 1.7.0.2.445.gcbdb3