git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Compiling git with makepp patch

From
DPDaniel Pfeiffer <occitan@t-online.de>
Date
Aug 25, 2010, 21:08 UTC
Message-ID
<4C75865E.5050804@t-online.de>
In-Reply-To
<201008230947.06777.trast@student.ethz.ch>
  la 08/23/2010 09:47 AM Thomas Rast skribis:
Show 25 quoted lines
> Daniel Pfeiffer wrote:
>>   # Shell quote;
>> -bindir_SQ = $(subst ','\'',$(bindir))#'
>> -gitwebdir_SQ = $(subst ','\'',$(gitwebdir))#'
>> -gitwebstaticdir_SQ = $(subst ','\'',$(gitwebdir)/static)#'
>> -SHELL_PATH_SQ = $(subst ','\'',$(SHELL_PATH))#'
>> -PERL_PATH_SQ  = $(subst ','\'',$(PERL_PATH))#'
>> -DESTDIR_SQ    = $(subst ','\'',$(DESTDIR))#'
>> +Q='
>> +# ' This comment is only to appease IDEs like Emacs.
>> +# The comment is on a new line, else makepp would see it as a quoted hash.
>> +bindir_SQ = $(subst $Q,'\'',$(bindir))
>> +gitwebdir_SQ = $(subst $Q,'\'',$(gitwebdir))
>> +gitwebstaticdir_SQ = $(subst $Q,'\'',$(gitwebdir)/static)
>> +SHELL_PATH_SQ = $(subst $Q,'\'',$(SHELL_PATH))
>> +PERL_PATH_SQ  = $(subst $Q,'\'',$(PERL_PATH))
>> +DESTDIR_SQ    = $(subst $Q,'\'',$(DESTDIR))
> Confusingly, you talk about comments above, but the real issue is that
> your makepp apparently gives the ' special meaning.  For once "info
> make" and "man 1p make" on my system agree on the semantics of ': none
> at all.  From the latter:
>
>    Early proposals stated that an "unquoted" number sign  was  treated  as  the
>    start of a comment. The make utility does not pay any attention to quotes. A
>    number sign starts a comment regardless of its surroundings.

If you look at the example I just sent to Ævar, that contains examples of how crazy the situation really is in gmake. What you cite here is wrong!

> So can you quote chapter and verse to show that there is anything to
> fix?

Well, I pointed you to makepp, which is subtly different from gmake, which you could. If you choose not to use it, please yourself!

coralament / best Grötens / liebe Grüße / best regards / elkorajn salutojn Daniel Pfeiffer

-- 
lerne / learn / apprends / lär dig / ucz się    Esperanto:
                     http://lernu.net  /  http://ikurso.net
Previous: Jakub NarebskiNext: Ævar Arnfjörð Bjarmason
Message 4 of 11 in “Compiling git with makepp patch”
  1. Daniel PfeifferAug 22, 2010
  2. Thomas RastAug 23, 2010
  3. Jakub NarebskiAug 23, 2010
  4. Daniel PfeifferAug 25, 2010
  5. Ævar Arnfjörð BjarmasonAug 23, 2010
  6. Daniel PfeifferAug 25, 2010
  7. Jonathan NiederAug 24, 2010
  8. Daniel PfeifferAug 25, 2010
  9. Andreas SchwabAug 25, 2010
  10. Junio C HamanoAug 25, 2010
  11. Jonathan NiederAug 26, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.