Re: Compiling git with makepp patch

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Aug 23, 2010, 20:27 UTC
Message-ID: <AANLkTinbTph=cggp4V=avorzrf9BT7vPtpanDtDtXm=q@mail.gmail.com>
In-Reply-To: <4C71A53F.2020108@t-online.de>

On Sun, Aug 22, 2010 at 22:31, Daniel Pfeiffer <occitan@t-online.de> wrote:

> Git has been giving our promise of Gnu make compatibility a hard
> time.

Aside from our bugs you can't make that promise if projects like Git need patches to work with makepp :)

Show 6 quoted lines

> The other thing caused me quite a headache before I understood:
>
> PERL_PATH_SQ  = $(subst ','\'',$(PERL_PATH))#'
>
> I suppose you added the comment for Emacs' syntax highlighting, to have an
> even number of unescaped quotes.

That was added by John 'Warthog9' Hawley, I wonder if that also came with a M-x report-emacs-bug, e.g. cperl-mode deals with that case, sounds like an easy-to-fix bug in makefile-gmake-mode.

Show 6 quoted lines

> The problem is makepp parses this line
> just like Emacs, so it doesn't find the comment, adding in the #' at the
> point of use, which completely screws the sed command.  (You might want to
> apply my fix to a few other makefiles, which have SQ variables, albeit
> without the syntax highlighting workaround, so they are only visually
> defect.)

The reason Emacs has issues is because it uses an ad-hoc regexp based parser that favours speed above correctness for syntax highlighting.

I'm surprised you've gotten this far with makepp if you don't tokenize comments and throw their contents away.