From: Daniel Pfeiffer Date: Wed, 25 Aug 2010 21:08:46 GMT Subject: Re: Compiling git with makepp patch Message-ID: <4C75865E.5050804@t-online.de> In-Reply-To: <201008230947.06777.trast@student.ethz.ch> la 08/23/2010 09:47 AM Thomas Rast skribis: > Daniel Pfeiffer wrote: >> # Shell quote; >> -bindir_SQ = $(subst ','\'',$(bindir))#' >> -gitwebdir_SQ = $(subst ','\'',$(gitwebdir))#' >> -gitwebstaticdir_SQ = $(subst ','\'',$(gitwebdir)/static)#' >> -SHELL_PATH_SQ = $(subst ','\'',$(SHELL_PATH))#' >> -PERL_PATH_SQ = $(subst ','\'',$(PERL_PATH))#' >> -DESTDIR_SQ = $(subst ','\'',$(DESTDIR))#' >> +Q=' >> +# ' This comment is only to appease IDEs like Emacs. >> +# The comment is on a new line, else makepp would see it as a quoted hash. >> +bindir_SQ = $(subst $Q,'\'',$(bindir)) >> +gitwebdir_SQ = $(subst $Q,'\'',$(gitwebdir)) >> +gitwebstaticdir_SQ = $(subst $Q,'\'',$(gitwebdir)/static) >> +SHELL_PATH_SQ = $(subst $Q,'\'',$(SHELL_PATH)) >> +PERL_PATH_SQ = $(subst $Q,'\'',$(PERL_PATH)) >> +DESTDIR_SQ = $(subst $Q,'\'',$(DESTDIR)) > Confusingly, you talk about comments above, but the real issue is that > your makepp apparently gives the ' special meaning. For once "info > make" and "man 1p make" on my system agree on the semantics of ': none > at all. From the latter: > > Early proposals stated that an "unquoted" number sign was treated as the > start of a comment. The make utility does not pay any attention to quotes. A > number sign starts a comment regardless of its surroundings. If you look at the example I just sent to Ævar, that contains examples of how crazy the situation really is in gmake. What you cite here is wrong! > So can you quote chapter and verse to show that there is anything to > fix? Well, I pointed you to makepp, which is subtly different from gmake, which you could. If you choose not to use it, please yourself! coralament / best Grötens / liebe Grüße / best regards / elkorajn salutojn Daniel Pfeiffer -- lerne / learn / apprends / lär dig / ucz się Esperanto: http://lernu.net / http://ikurso.net