git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] test-lib: Multi-prereq support only checked the last prereq

From
Johannes Sixt <j6t@kdbg.org>
Date
Aug 13, 2010, 20:28 UTC
Message-ID
<4C65AAF8.80009@kdbg.org>
In-Reply-To
<1281528278-15659-1-git-send-email-avarab@gmail.com>
Am 11.08.2010 14:04, schrieb Ævar Arnfjörð Bjarmason:
> -		say_color skip "ok $test_count # skip $1 (prereqs: $prereq)"
> +		say_color skip "ok $test_count # skip $1 (missing $missing_prereq of $prereq)"

This needs fixing: When a test is skipped due to being listed in GIT_SKIP_TESTS, then the output looks like this:

ok 47 # skip --ignore-submodules=untracked suppresses submodules with untracked content (missing SANITY,POSIXPERM of )

(In this case, there was a test before number 47 that was skipped due to missing prerequisite.)

Please also note that - when a prerequisite is not satisfied - the text in parentheses does not say "prerequisite" or similar anymore. IMO, this should be added back.

-- Hannes
Previous: Ævar Arnfjörð BjarmasonNext: Jonathan Nieder
Message 4 of 7 in “test-lib: Multi-prereq support only checked the last prereq”
  1. test-lib: Multi-prereq support only checked the last prereqÆvar Arnfjörð Bjarmason, Aug 10, 2010
  2. Jonathan NiederAug 11, 2010
  3. test-lib: Multi-prereq support only checked the last prereqÆvar Arnfjörð Bjarmason, Aug 11, 2010
  4. Johannes SixtAug 13, 2010
  5. tests: simplify "missing PREREQ" messageJonathan Nieder, Aug 24, 2010
  6. Johannes SixtAug 24, 2010
  7. Junio C HamanoAug 24, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.