Re: [PATCH] tests: simplify "missing PREREQ" message

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Aug 24, 2010, 10:16 UTC
Message-ID: <4C739BE2.5060200@viscovery.net>
In-Reply-To: <20100824073410.GA5562@burratino>

Am 8/24/2010 9:34, schrieb Jonathan Nieder:

Show 16 quoted lines

> @@ -417,8 +417,14 @@ test_skip () {
>  	fi
>  	case "$to_skip" in
>  	t)
> +		of_prereq=
> +		if test "$missing_prereq" != "$prereq"
> +		then
> +			of_prereq=" of $prereq"
> +		fi
> +
>  		say_color skip >&3 "skipping test: $@"
> -		say_color skip "ok $test_count # skip $1 (missing $missing_prereq of $prereq)"
> +		say_color skip "ok $test_count # skip $1 (missing $missing_prereq${of_prereq})"
>  		: true
>  		;;
>  	*)

While you are touching this area, would also fix messages like these:

ok 70 # skip set --path (missing of ) ok 71 # skip get --path (missing of HOMEVAR) ok 72 # skip get --path copes with unset $HOME (missing of )

which are due to GIT_SKIP_TESTS=t1300.7[012]

-- Hannes